iOS gtest launcher: retry tests in one big batch

iOS gtest launcher: retry tests in one big batch

Without it the overhead of serialized ios simulator run is too big.

BUG=426870
R=sky@chromium.org, smut@google.com

Committed: https://chromium.googlesource.com/chromium/src/+/5a34a29a62f5468d9de244bca3295347f7afbd56

[Paweł Hajdan Jr., 2015-01-28 16:16:46]

phajdan.jr@chromium.org changed reviewers:
+ lliabraa@chromium.org, sky@chromium.org

[lliabraa, 2015-01-28 16:22:52]

lliabraa@chromium.org changed reviewers:
+ smut@chromium.org

[lliabraa, 2015-01-28 16:22:53]

seems okay but I'm not familiar with this infra. Can you please send these
reviews to smut?

[smut, 2015-01-28 19:36:25]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2015-01-28 19:36:26]

I would'dve liked to have reviewed or at least seen ios_test_launcher.cc from
the start.

lgtm

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/test_laun...
File base/test/launcher/test_launcher_ios.cc (right):

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/test_laun...
base/test/launcher/test_launcher_ios.cc:137: RunUnitTestsBatch(test_launcher,
this, test_names, launch_flags);
This is about what we have implemented downstream in our Python scripts. However
if one of the retried tests crashes the entire suite, there won't be any retries
for the tests that come after it.

[sky, 2015-01-28 21:21:14]

LGTM

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/unit_test...
File base/test/launcher/unit_test_launcher.cc (right):

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/unit_test...
base/test/launcher/unit_test_launcher.cc:129: for (size_t i = 0; i <
test_names.size(); i++) {
nit: use new for loop for less code.

[Paweł Hajdan Jr., 2015-01-29 13:37:54]

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/unit_test...
File base/test/launcher/unit_test_launcher.cc (right):

https://codereview.chromium.org/886463003/diff/1/base/test/launcher/unit_test...
base/test/launcher/unit_test_launcher.cc:129: for (size_t i = 0; i <
test_names.size(); i++) {
On 2015/01/28 21:21:14, sky wrote:
> nit: use new for loop for less code.

Done.

[commit-bot: I haz the power, 2015-01-29 13:40:40]

Patchset 2 (id:??) landed as
https://crrev.com/5a34a29a62f5468d9de244bca3295347f7afbd56
Cr-Commit-Position: refs/heads/master@{#313696}

[Paweł Hajdan Jr., 2015-01-29 13:41:13]

Committed patchset #2 (id:20001) manually as
5a34a29a62f5468d9de244bca3295347f7afbd56 (presubmit successful).