Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886453002: Add checks on services' public BUILD.gn files to //mojo/PRESUBMIT.py (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add checks on services' public BUILD.gn files to //mojo/PRESUBMIT.py This CL extends //mojo/PRESUBMIT.py with the following checks on services' public BUILD.gn files: - No references to the Mojo SDK via absolute paths - No references to other services' buildfiles via absolute paths - No other absolute-path deps R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/915d6bdef4ad63f3a942d504784cd8d213631e6f

Patch Set 1 #

Patch Set 2 : Refactorings #

Patch Set 3 : Nits #

Patch Set 4 : Remove refactoring #

Patch Set 5 : Add definition of services vars #

Total comments: 4

Patch Set 6 : Response to review #

Patch Set 7 : Fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -29 lines) Patch
M mojo/PRESUBMIT.py View 1 2 3 4 5 6 8 chunks +54 lines, -29 lines 0 comments Download
M mojo/PRESUBMIT_test.py View 1 2 3 4 5 6 4 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
blundell
5 years, 10 months ago (2015-01-28 14:51:14 UTC) #2
qsr
https://codereview.chromium.org/886453002/diff/80001/mojo/PRESUBMIT.py File mojo/PRESUBMIT.py (right): https://codereview.chromium.org/886453002/diff/80001/mojo/PRESUBMIT.py#newcode16 mojo/PRESUBMIT.py:16: "SDK": [ "//testing/gtest", You should indent by 4. https://codereview.chromium.org/886453002/diff/80001/mojo/PRESUBMIT.py#newcode101 ...
5 years, 10 months ago (2015-01-28 14:57:53 UTC) #3
blundell
https://codereview.chromium.org/886453002/diff/80001/mojo/PRESUBMIT.py File mojo/PRESUBMIT.py (right): https://codereview.chromium.org/886453002/diff/80001/mojo/PRESUBMIT.py#newcode16 mojo/PRESUBMIT.py:16: "SDK": [ "//testing/gtest", On 2015/01/28 14:57:53, qsr wrote: > ...
5 years, 10 months ago (2015-01-28 15:23:02 UTC) #4
blundell
Indentation fixed :)
5 years, 10 months ago (2015-01-28 15:43:12 UTC) #5
qsr
lgtm
5 years, 10 months ago (2015-01-28 15:45:42 UTC) #6
blundell
5 years, 10 months ago (2015-01-28 15:47:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
915d6bdef4ad63f3a942d504784cd8d213631e6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698