SignedCertificateTimestamp storing & serialization code.

net/cert/sct_status_flags.h

Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
new file mode 100644
index 0000000000000000000000000000000000000000..a414a6ae1cdf698248be262f7bf9f0a6c643c252
--- /dev/null
+++ b/net/cert/sct_status_flags.h
@@ -0,0 +1,19 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[wtc, 2013/11/27 16:32:41]

Although it's not required for the build, please add this new header to
net/net.gyp.

[alcutter, 2013/11/27 18:05:55]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_CERT_SCT_STATUS_H_
+#define NET_CERT_SCT_STATUS_H_

[wtc, 2013/11/27 16:32:41]

The include guard macro should be updated to match the header file's pathname.

[alcutter, 2013/11/27 18:05:55]

Ay ay, done.

+
+namespace net {
+
+enum SignedCertificateTimestampVerificationStatus {

[wtc, 2013/11/27 16:32:41]

Please document this enum type and its four values.

Nit: the enum type's name could be shorter. Perhaps we can put this inside the
"ct" namespace and name this enum type "ct::SCTStatus" or "ct::SCTVerifyStatus".

[alcutter, 2013/11/27 18:05:55]

Done.
Done.

+  SCT_STATUS_UNSET = 0,

[wtc, 2013/11/27 16:32:41]

Nit: it's not clear what "unset" means.

[alcutter, 2013/11/27 18:05:55]

This was a change in response to Eran's comment earlier, just to avoid a default
value of 0 ever being mis-interpreted as a real state, I was going to use
INVALID but that's already taken and means something else.

+  SCT_STATUS_LOG_UNKNOWN = 1,
+  SCT_STATUS_INVALID = 2,
+  SCT_STATUS_OK = 3,
+};
+
+}  // namespace net
+
+#endif  // NET_CERT_SCT_STATUS_H_