net/cert/sct_status_flags.h - Issue 88643002: SignedCertificateTimestamp storing & serialization code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/sct_status_flags.h

Issue 88643002: SignedCertificateTimestamp storing & serialization code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erans_patches

Patch Set: Fixes for jam. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	wtc 2013/11/27 16:32:41 Although it's not required for the build, please a Although it's not required for the build, please add this new header to net/net.gyp. alcutter 2013/11/27 18:05:55 Done. Show quoted text On 2013/11/27 16:32:41, wtc wrote: > > Although it's not required for the build, please add this new header to > net/net.gyp. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_CERT_SCT_STATUS_H_

	6 #define NET_CERT_SCT_STATUS_H_
	wtc 2013/11/27 16:32:41 The include guard macro should be updated to match The include guard macro should be updated to match the header file's pathname. alcutter 2013/11/27 18:05:55 Ay ay, done. Show quoted text On 2013/11/27 16:32:41, wtc wrote: > > The include guard macro should be updated to match the header file's pathname. Ay ay, done.
	7

	8 namespace net {

	9

	10 enum SignedCertificateTimestampVerificationStatus {
	wtc 2013/11/27 16:32:41 Please document this enum type and its four values Please document this enum type and its four values. Nit: the enum type's name could be shorter. Perhaps we can put this inside the "ct" namespace and name this enum type "ct::SCTStatus" or "ct::SCTVerifyStatus". alcutter 2013/11/27 18:05:55 Done. Show quoted text On 2013/11/27 16:32:41, wtc wrote: > > Please document this enum type and its four values. Done. Show quoted text > > Nit: the enum type's name could be shorter. Perhaps we can put this inside the > "ct" namespace and name this enum type "ct::SCTStatus" or "ct::SCTVerifyStatus". Done.
	11 SCT_STATUS_UNSET = 0,
	wtc 2013/11/27 16:32:41 Nit: it's not clear what "unset" means. Nit: it's not clear what "unset" means. alcutter 2013/11/27 18:05:55 This was a change in response to Eran's comment ea Show quoted text On 2013/11/27 16:32:41, wtc wrote: > > Nit: it's not clear what "unset" means. This was a change in response to Eran's comment earlier, just to avoid a default value of 0 ever being mis-interpreted as a real state, I was going to use INVALID but that's already taken and means something else.
	12 SCT_STATUS_LOG_UNKNOWN = 1,

	13 SCT_STATUS_INVALID = 2,

	14 SCT_STATUS_OK = 3,

	15 };

	16

	17 } // namespace net

	18

	19 #endif // NET_CERT_SCT_STATUS_H_

OLD	NEW

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | net/cert/signed_certificate_timestamp.h » ('j') | net/cert/signed_certificate_timestamp.cc » ('J')