Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886413004: move HelloWorld to be a peer of SampleApp (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move HelloWorld to be a peer of SampleApp This is working towards making a simple example part of the buildbot compile step and removing SkExamples from the experimental directory. This works on Mac, Windows, and Linux but isn't complete for Android, ChromeOS and iOS. Committed: https://skia.googlesource.com/skia/+/52edc4d05380c88de5b334479ad8e537ef2b4925

Patch Set 1 #

Patch Set 2 : fix mac port of hello world example #

Patch Set 3 : exclude hello world example if gpu is disallowed #

Patch Set 4 : exclude android as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -107 lines) Patch
A + example/HelloWorld.h View 2 chunks +6 lines, -26 lines 0 comments Download
A + example/HelloWorld.cpp View 9 chunks +16 lines, -16 lines 0 comments Download
A + example/mac/HelloWorld.xib View 1 9 chunks +7 lines, -49 lines 0 comments Download
A + example/mac/HelloWorld-Info.plist View 1 1 chunk +1 line, -1 line 0 comments Download
A + example/mac/HelloWorldDelegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + example/mac/HelloWorldDelegate.mm View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + example/mac/HelloWorldNSView.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + example/mac/HelloWorldNSView.mm View 1 1 chunk +8 lines, -9 lines 0 comments Download
A gyp/example.gyp View 1 1 chunk +51 lines, -0 lines 0 comments Download
M gyp/most.gyp View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
caryclark
5 years, 10 months ago (2015-02-02 18:30:45 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-02 19:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886413004/40001
5 years, 10 months ago (2015-02-02 20:17:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1810)
5 years, 10 months ago (2015-02-02 20:19:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886413004/60001
5 years, 10 months ago (2015-02-02 20:48:58 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 20:55:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/52edc4d05380c88de5b334479ad8e537ef2b4925

Powered by Google App Engine
This is Rietveld 408576698