Handle createCDM() when frame destroyed

media/blink/webcontentdecryptionmoduleaccess_impl.h

Index: media/blink/webcontentdecryptionmoduleaccess_impl.h
diff --git a/media/blink/webcontentdecryptionmoduleaccess_impl.h b/media/blink/webcontentdecryptionmoduleaccess_impl.h
index 9d54823775104a1fa391625080af68d182d513bb..d7de74b3d697a887e0e67d9865448ede746ed77f 100644
--- a/media/blink/webcontentdecryptionmoduleaccess_impl.h
+++ b/media/blink/webcontentdecryptionmoduleaccess_impl.h
@@ -7,6 +7,7 @@
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "media/base/cdm_factory.h"
 #include "third_party/WebKit/public/platform/WebContentDecryptionModuleAccess.h"
 #include "third_party/WebKit/public/platform/WebMediaKeySystemConfiguration.h"
@@ -19,6 +20,8 @@ class WebLocalFrame;
 
 namespace media {
 
+class WebEncryptedMediaClientImpl;
+
 class WebContentDecryptionModuleAccessImpl
     : public blink::WebContentDecryptionModuleAccess {
  public:
@@ -26,7 +29,7 @@ class WebContentDecryptionModuleAccessImpl
       const blink::WebString& key_system,
       const blink::WebMediaKeySystemConfiguration& configuration,
       const blink::WebSecurityOrigin& security_origin,
-      CdmFactory* cdm_factory);
+      base::WeakPtr<WebEncryptedMediaClientImpl> client);

[xhwang, 2015/02/03 18:45:49]

pass by const ref?

[jrummell, 2015/02/03 20:01:14]

Done.

   virtual ~WebContentDecryptionModuleAccessImpl();
 
   // blink::WebContentDecryptionModuleAccess interface.
@@ -39,14 +42,14 @@ class WebContentDecryptionModuleAccessImpl
       const blink::WebString& key_system,
       const blink::WebMediaKeySystemConfiguration& configuration,
       const blink::WebSecurityOrigin& security_origin,
-      CdmFactory* cdm_factory);
+      base::WeakPtr<WebEncryptedMediaClientImpl> client);

[xhwang, 2015/02/03 18:45:49]

ditto

[jrummell, 2015/02/03 20:01:14]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(WebContentDecryptionModuleAccessImpl);
 
   blink::WebString key_system_;
   blink::WebMediaKeySystemConfiguration configuration_;
   blink::WebSecurityOrigin security_origin_;
-  CdmFactory* cdm_factory_;
+  base::WeakPtr<WebEncryptedMediaClientImpl> client_;

[xhwang, 2015/02/03 18:45:49]

Comment about why this needs to be a weak ptr?

[jrummell, 2015/02/03 20:01:14]

Done.

 };
 
 }  // namespace media