Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 886383002: Fixing options parser. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M download_firefox_nightly.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
5 years, 10 months ago (2015-02-02 12:00:11 UTC) #2
phoglund_chromium
Committed patchset #1 (id:1) manually as r293901 (presubmit successful).
5 years, 10 months ago (2015-02-02 12:00:41 UTC) #3
kjellander_chromium
so you didn't test it locally even in the previous fix? ;) lgtm
5 years, 10 months ago (2015-02-02 12:40:21 UTC) #4
phoglund_chromium
5 years, 10 months ago (2015-02-02 13:00:59 UTC) #5
Message was sent while issue was closed.
On 2015/02/02 12:40:21, kjellander wrote:
> so you didn't test it locally even in the previous fix? ;)
> 
> lgtm

Sigh, no.

Powered by Google App Engine
This is Rietveld 408576698