Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 886353008: Fix an error in docs for manifest requirements for usbDevices permission (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an error in docs for manifest requirements for usbDevices permission The "usbDevices" entry in permission list should be inside an object Committed: https://crrev.com/e69165719bc77212e911d18c24558c72180d33c9 Cr-Commit-Position: refs/heads/master@{#314971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/common/extensions/docs/templates/articles/app_usb.html View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
5 years, 10 months ago (2015-02-06 03:09:19 UTC) #2
Ken Rockot(use gerrit already)
doh. thanks for the fix! lgtm
5 years, 10 months ago (2015-02-06 03:11:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886353008/1
5 years, 10 months ago (2015-02-06 03:12:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:54:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:55:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e69165719bc77212e911d18c24558c72180d33c9
Cr-Commit-Position: refs/heads/master@{#314971}

Powered by Google App Engine
This is Rietveld 408576698