Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 886353005: [VAAPI-DRM] Fix GpuMemoryBuffer format when creating a pixmap (Closed)

Created:
5 years, 10 months ago by dnicoara
Modified:
5 years, 10 months ago
Reviewers:
achaulk, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[VAAPI-DRM] Fix GpuMemoryBuffer format when creating a pixmap Reverting back to using BGRA_8888 format to fix the following errors: [0204/075331:ERROR:gl_image_linux_dma_buffer.cc(79)] Invalid format: 6408 [0204/075331:ERROR:vaapi_drm_picture.cc(110)] Failed to create GLImage BUG=447798 TEST=Ran ./video_decode_accelerator_test and verified that the above error isn't present anymore Committed: https://crrev.com/aadfa1a5205be20bc303c0e60ae30a2b39ba10f0 Cr-Commit-Position: refs/heads/master@{#314735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/vaapi_drm_picture.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
dnicoara
PTAL This is a follow-up to https://codereview.chromium.org/858653002
5 years, 10 months ago (2015-02-04 16:20:53 UTC) #2
Pawel Osciak
lgtm, but please provide a TEST= line in CL description. Thanks.
5 years, 10 months ago (2015-02-05 02:38:31 UTC) #3
dnicoara
On 2015/02/05 02:38:31, Pawel Osciak wrote: > lgtm, but please provide a TEST= line in ...
5 years, 10 months ago (2015-02-05 02:46:26 UTC) #4
Pawel Osciak
On 2015/02/05 02:46:26, dnicoara wrote: > On 2015/02/05 02:38:31, Pawel Osciak wrote: > > lgtm, ...
5 years, 10 months ago (2015-02-05 02:47:18 UTC) #5
dnicoara
On 2015/02/05 02:47:18, Pawel Osciak wrote: > On 2015/02/05 02:46:26, dnicoara wrote: > > On ...
5 years, 10 months ago (2015-02-05 02:51:20 UTC) #6
Pawel Osciak
lgtm Ah, thanks for the explanation. I didn't notice the overlay CL changed the format. ...
5 years, 10 months ago (2015-02-05 03:18:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886353005/1
5 years, 10 months ago (2015-02-05 03:19:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 03:37:44 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:38:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aadfa1a5205be20bc303c0e60ae30a2b39ba10f0
Cr-Commit-Position: refs/heads/master@{#314735}

Powered by Google App Engine
This is Rietveld 408576698