Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Issue 886353004: Stop unfinished speech query from appearing in app list reopen. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@separate_start_page_tile_container
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop unfinished speech query from appearing in app list reopen. This CL fixes an issue where a speech query in the app list, that was interrupted by the app list closing, would complete when the app list was reopened. BUG=440061 Committed: https://crrev.com/332f0228d0231cf7b3c7d9bdbc4b9c3d35e9899c Cr-Commit-Position: refs/heads/master@{#314523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
5 years, 10 months ago (2015-02-04 07:34:35 UTC) #2
Anand Mistry (off Chromium)
lgtm
5 years, 10 months ago (2015-02-04 07:37:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886353004/1
5 years, 10 months ago (2015-02-04 07:41:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 08:32:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 08:33:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/332f0228d0231cf7b3c7d9bdbc4b9c3d35e9899c
Cr-Commit-Position: refs/heads/master@{#314523}

Powered by Google App Engine
This is Rietveld 408576698