Pass InterpolationQuality into DragImage to respect image-rendering:pixelated.

Source/platform/DragImage.h

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DragImage_h
 #define DragImage_h
 
 #include "platform/geometry/IntSize.h"
 #include "platform/graphics/ImageOrientation.h"
 #include "platform/graphics/paint/DisplayItemClient.h"
+#include "skia/ext/image_operations.h"

[Justin Novosad, 2015/02/05 05:06:24]

I realize this dependency is not new to this patch (the cpp file already has
it), but this is an obvious layering violation. You must not use include files
from chromium in blink.  There are two ways around this:
a) use skia directly instead of using chromium's skia wrappers. Blink has it's
own graphics helpers and utilities in Source/platform/graphics.
b) use a dependency inversion pattern to call into chromium the legal way
(example: blink::Platform vs BlinkPlatformImpl)
If we start being cavalier about circular dependencies between blink and
chromium, someday we are going to have a bad time.

I don't want to block this CL on resolving the bad dependency, but I would like
you to avoid spreading it any further. For now, could you just make this
interface use blink's InterpolationQuality enum or skia's SkPaint::FilterLevel?

[jackhou1, 2015/02/10 01:53:56]

Done.

 #include "third_party/skia/include/core/SkBitmap.h"
 #include "wtf/Forward.h"
 
 namespace blink {
 
 class FontDescription;
 class Image;
 class KURL;
 
 class PLATFORM_EXPORT DragImage {
 public:
-    static PassOwnPtr<DragImage> create(Image*, RespectImageOrientationEnum = DoNotRespectImageOrientation, float deviceScaleFactor = 1);
+    typedef skia::ImageOperations::ResizeMethod ResizeMethod;
+
+    static PassOwnPtr<DragImage> create(Image*, RespectImageOrientationEnum = DoNotRespectImageOrientation, float deviceScaleFactor = 1, ResizeMethod = ResizeMethod::RESIZE_LANCZOS3);
     static PassOwnPtr<DragImage> create(const KURL&, const String& label, const FontDescription& systemFont, float deviceScaleFactor);
     ~DragImage();
 
     const SkBitmap& bitmap() { return m_bitmap; }
     float resolutionScale() const { return m_resolutionScale; }
     IntSize size() const { return IntSize(m_bitmap.width(), m_bitmap.height()); }
 
     void fitToMaxSize(const IntSize& srcSize, const IntSize& maxSize);
     void scale(float scaleX, float scaleY);
     void dissolveToFraction(float fraction);
 
 private:
-    DragImage(const SkBitmap&, float resolutionScale);
+    DragImage(const SkBitmap&, float resolutionScale, ResizeMethod);
 
     DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }
 
     SkBitmap m_bitmap;
     float m_resolutionScale;
+    ResizeMethod m_resizeMethod;
 };
 
 }
 
 #endif // DragImage_h