Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 886323004: ozone: dri: Fix undefined references in DRI platform GN build (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: dri: Fix undefined references in DRI platform GN build We need to export everything that is used by the tests and fix the test target to depend on //ui/ozone instead of directly on the platform source_set. The latter builds a copy of the platform directly into the test binary, creating unresolved references to other parts of //ui/ozone. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) Committed: https://crrev.com/349b8fae7983101c7f77c56b9a3ed973f22d5358 Cr-Commit-Position: refs/heads/master@{#314607}

Patch Set 1 #

Patch Set 2 : also fix gyp build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M ui/ozone/platform/dri/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/crtc_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_buffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager_legacy.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/overlay_plane.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/scoped_drm_types.h View 2 chunks +11 lines, -10 lines 0 comments Download
M ui/ozone/platform/dri/screen_manager.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 10 months ago (2015-02-04 01:06:46 UTC) #2
dnicoara
Should we do the same thing for the GYP build, just to stay consistent?
5 years, 10 months ago (2015-02-04 15:14:49 UTC) #3
spang
On 2015/02/04 15:14:49, dnicoara wrote: > Should we do the same thing for the GYP ...
5 years, 10 months ago (2015-02-04 17:40:47 UTC) #4
dnicoara
lgtm
5 years, 10 months ago (2015-02-04 17:41:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886323004/20001
5 years, 10 months ago (2015-02-04 18:40:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 19:21:07 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:22:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/349b8fae7983101c7f77c56b9a3ed973f22d5358
Cr-Commit-Position: refs/heads/master@{#314607}

Powered by Google App Engine
This is Rietveld 408576698