[turbofan]: Small visualizer cleanup and fix for string handling

[turbofan]: Small visualizer cleanup and fix for string handling

R=mstarzinger@chromium.org

Committed: https://crrev.com/21cdb967a40fd11c98a4947b6435dffa2bf44caf
Cr-Commit-Position: refs/heads/master@{#26399}

[danno, 2015-02-02 22:01:57]

PTAL, please send to CQ if it lgty

[Michael Starzinger, 2015-02-03 12:24:20]

LGTM.

[Michael Starzinger, 2015-02-03 12:24:25]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-02-03 12:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/886313006/1

[commit-bot: I haz the power, 2015-02-03 13:11:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-03 13:11:12]

Patchset 1 (id:??) landed as
https://crrev.com/21cdb967a40fd11c98a4947b6435dffa2bf44caf
Cr-Commit-Position: refs/heads/master@{#26399}

[saper-retired, 2015-05-06 07:39:59]

On 2015/02/03 13:11:12, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/21cdb967a40fd11c98a4947b6435dffa2bf44caf
> Cr-Commit-Position: refs/heads/master@{#26399}

I just ran into this using gcc 4.8.4:

g++48 '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER'
'-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' -I../deps/v8  -pthread -Wall -Wextra
-Wno-unused-parameter -m64 -fno-strict-aliasing -I/usr/local/include -O3
-ffunction-sections -fdata-sections -fno-omit-frame-pointer -fdata-sections
-ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF
/wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/.deps//wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o.d.raw
-O2 -pipe -fstack-protector -Wl,-rpath=/usr/local/lib/gcc48 -fno-strict-aliasing
-Wl,-rpath=/usr/local/lib/gcc48 -c -o
/wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o
../deps/v8/src/compiler/graph-visualizer.cc
In file included from ../deps/v8/src/compiler/graph-visualizer.cc:5:0:
../deps/v8/src/compiler/graph-visualizer.h:23:1: error: 'FILE' does not name a
type
 FILE* OpenVisualizerLogFile(CompilationInfo* info, const char* phase,
 ^
deps/v8/tools/gyp/v8_base.target.mk:370: recipe for target
'/wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o'
failed


http://code.google.com/p/v8/issues/detail?id=4079

[saper, 2015-05-06 10:39:33]

Follow up submitted as https://codereview.chromium.org/1128053002/