Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 886313005: make getContentKey() available in GrGpuResource public interface (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix resolve error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M include/gpu/GrGpuResource.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache2.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bsalomon
This allows creating resource content keys that wrap other keys (e.g. npot) without requiring the ...
5 years, 10 months ago (2015-02-02 21:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886313005/20001
5 years, 10 months ago (2015-02-02 22:01:45 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/85ed2db092e75db41b711b9116a8d5b465fc2b0c
5 years, 10 months ago (2015-02-02 22:08:12 UTC) #5
stephana
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/864343005/ by stephana@google.com. ...
5 years, 10 months ago (2015-02-02 22:51:40 UTC) #6
bsalomon
On 2015/02/02 22:51:40, stephana wrote: > A revert of this CL (patchset #2 id:20001) has ...
5 years, 10 months ago (2015-02-03 01:24:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886313005/20001
5 years, 10 months ago (2015-02-03 01:25:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/563ff60b33fa50b9c6a48dd048b8b36a88596668
5 years, 10 months ago (2015-02-03 01:25:29 UTC) #11
robertphillips
5 years, 10 months ago (2015-02-03 14:01:46 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698