Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8863: Add some extra unit-tests to make sure we cover all permutations of {basic_au... (Closed)

Created:
12 years, 1 month ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add some extra unit-tests to make sure we cover all permutations of {basic_auth, digest_auth} x {empty_username, empty_password}. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4113

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M net/http/http_auth_handler_basic_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Some extra variants to complement your added test.
12 years, 1 month ago (2008-10-28 23:50:04 UTC) #1
wtc
LGTM. http://codereview.chromium.org/8863/diff/1/2 File net/http/http_auth_handler_basic_unittest.cc (right): http://codereview.chromium.org/8863/diff/1/2#newcode21 Line 21: // Empty password and empty username. Nit: ...
12 years, 1 month ago (2008-10-28 23:56:12 UTC) #2
eroman
Thanks, done.
12 years, 1 month ago (2008-10-28 23:59:19 UTC) #3
wtc
12 years, 1 month ago (2008-10-29 00:00:14 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698