Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 886263003: Remove mask painting. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove mask painting. Now that we don't have -webkit-mask-*, this is dead code. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7da61820bcba894375f985399a590619864b8ea0

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -99 lines) Patch
M sky/engine/core/rendering/InlineBox.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 2 chunks +0 lines, -50 lines 0 comments Download
M sky/engine/core/rendering/PaintPhase.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 10 months ago (2015-02-02 04:36:32 UTC) #2
ojan
5 years, 10 months ago (2015-02-02 04:37:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7da61820bcba894375f985399a590619864b8ea0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698