Issue 886263002: Move SharedTimer implementation into sky/engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886263002: Move SharedTimer implementation into sky/engine (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel, ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move SharedTimer implementation into sky/engine Now that sky/engine can talk to base directly, there's no reason to use Platform::current to implement SharedTimer. Instead, we can just implement it directly in SharedTimer.cpp. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2ef3d7624804d575ceb34892fb62ce62016ac933

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -165 lines)			Patch
M	sky/engine/platform/SharedTimer.cpp	View	1	1 chunk	+75 lines, -28 lines	0 comments	Download
M	sky/engine/testing/platform/platform_impl.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	sky/engine/testing/platform/platform_impl.cc	View		2 chunks	+1 line, -53 lines	0 comments	Download
M	sky/viewer/platform/platform_impl.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	sky/viewer/platform/platform_impl.cc	View		2 chunks	+1 line, -49 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 10 months ago (2015-02-01 17:35:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2ef3d7624804d575ceb34892fb62ce62016ac933 (presubmit successful).