Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: build/config/win/BUILD.gn

Issue 886243002: Revert "Fix chrome target in Windows GN build." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/win/visual_studio_version.gni") 5 import("//build/config/win/visual_studio_version.gni")
6 6
7 # Compiler setup for the Windows SDK. Applied to all targets. 7 # Compiler setup for the Windows SDK. Applied to all targets.
8 config("sdk") { 8 config("sdk") {
9 # The include path is the stuff returned by the script. 9 # The include path is the stuff returned by the script.
10 #include_dirs = msvc_config[0] TODO(brettw) make this work. 10 #include_dirs = msvc_config[0] TODO(brettw) make this work.
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 # This default linker setup is provided separately from the SDK setup so 57 # This default linker setup is provided separately from the SDK setup so
58 # targets who want different library configurations can remove this and specify 58 # targets who want different library configurations can remove this and specify
59 # their own. 59 # their own.
60 config("common_linker_setup") { 60 config("common_linker_setup") {
61 ldflags = [ 61 ldflags = [
62 "/FIXED:NO", 62 "/FIXED:NO",
63 "/ignore:4199", 63 "/ignore:4199",
64 "/ignore:4221", 64 "/ignore:4221",
65 "/NXCOMPAT", 65 "/NXCOMPAT",
66
67 # Suggested by Microsoft Devrel to avoid
68 # LINK : fatal error LNK1248: image size (80000000)
69 # exceeds maximum allowable size (80000000)
70 # which started happening more regularly after VS2013 Update 4.
71 "/maxilksize:2147483647",
72 ] 66 ]
73 67
74 # ASLR makes debugging with windbg difficult because Chrome.exe and 68 # ASLR makes debugging with windbg difficult because Chrome.exe and
75 # Chrome.dll share the same base name. As result, windbg will name the 69 # Chrome.dll share the same base name. As result, windbg will name the
76 # Chrome.dll module like chrome_<base address>, where <base address> 70 # Chrome.dll module like chrome_<base address>, where <base address>
77 # typically changes with each launch. This in turn means that breakpoints in 71 # typically changes with each launch. This in turn means that breakpoints in
78 # Chrome.dll don't stick from one launch to the next. For this reason, we 72 # Chrome.dll don't stick from one launch to the next. For this reason, we
79 # turn ASLR off in debug builds. 73 # turn ASLR off in debug builds.
80 if (is_debug) { 74 if (is_debug) {
81 ldflags += [ "/DYNAMICBASE:NO" ] 75 ldflags += [ "/DYNAMICBASE:NO" ]
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 125
132 # Nominmax -------------------------------------------------------------------- 126 # Nominmax --------------------------------------------------------------------
133 127
134 # Some third party code defines NOMINMAX before including windows.h, which 128 # Some third party code defines NOMINMAX before including windows.h, which
135 # then causes warnings when it's been previously defined on the command line. 129 # then causes warnings when it's been previously defined on the command line.
136 # For such targets, this config can be removed. 130 # For such targets, this config can be removed.
137 131
138 config("nominmax") { 132 config("nominmax") {
139 defines = [ "NOMINMAX" ] 133 defines = [ "NOMINMAX" ]
140 } 134 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698