Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 886243002: Revert "Fix chrome target in Windows GN build." (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
Slava Chigrin, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, extensions-reviews_chromium.org, tfarina, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, ben+mojo_chromium.org, darin (slow to review), jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix chrome target in Windows GN build." This reverts commit 61944aec76677366442bacbf6b60cccf1508bca3. It looks like this is overloading the win bots for some reason that we'll have to investigate. TBR=brettw@chromium.org, vchigrin@yandex-team.ru

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -69 lines) Patch
M BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 5 chunks +21 lines, -5 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/browser_watcher/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/invalidation/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dirk Pranke
5 years, 10 months ago (2015-01-31 18:20:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886243002/1
5 years, 10 months ago (2015-01-31 18:20:56 UTC) #3
brettw
On 2015/01/31 18:20:56, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-01-31 18:24:23 UTC) #4
Dirk Pranke
On 2015/01/31 18:24:23, brettw wrote: > On 2015/01/31 18:20:56, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-01-31 18:34:17 UTC) #6
Dirk Pranke
On 2015/01/31 18:34:17, Dirk Pranke wrote: > On 2015/01/31 18:24:23, brettw wrote: > > Can ...
5 years, 10 months ago (2015-01-31 18:34:47 UTC) #7
tfarina
On Sat, Jan 31, 2015 at 4:34 PM, <dpranke@chromium.org> wrote: > On 2015/01/31 18:34:17, Dirk ...
5 years, 10 months ago (2015-02-01 12:58:05 UTC) #8
brettw
Something weird is going on. The trybot is happy and only taking 50 mins. The ...
5 years, 10 months ago (2015-02-01 17:46:05 UTC) #9
Dirk Pranke
5 years, 10 months ago (2015-02-03 23:57:39 UTC) #10
Message was sent while issue was closed.
Closing .. it looks like we'll be able to make things work without having to
revert everything.

Powered by Google App Engine
This is Rietveld 408576698