Issue 886233003: [Search] Identity check for New Tab Page should use canonicalized form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886233003: [Search] Identity check for New Tab Page should use canonicalized form (Closed)

Created:
5 years, 10 months ago by Mathieu

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Search] Identity check for New Tab Page should use canonicalized form Was causing a bug where identities were slightly different. BUG=453792 Review URL: https://codereview.chromium.org/864223006 Cr-Commit-Position: refs/heads/master@{#313955} (cherry picked from commit ed8d517fc97a8b0c3542669279b0482727255a32) Committed: https://chromium.googlesource.com/chromium/src/+/2ddc774397497fa680c8846e34a16629577a6c16

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -4 lines)			Patch
M	chrome/browser/ui/search/search_tab_helper.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper_unittest.cc	View	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mathieu

5 years, 10 months ago (2015-01-31 18:35:40 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ddc774397497fa680c8846e34a16629577a6c16.

Expand Messages | Collapse Messages