Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: Source/modules/webaudio/AudioNode.h

Issue 886173004: Fix AudioNode.disconnect() to support selective disconnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: JS argument evaluation order fixed. More comments added. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioNode.h
diff --git a/Source/modules/webaudio/AudioNode.h b/Source/modules/webaudio/AudioNode.h
index 56a5e2904f6f31fead109e0f2838af0a56fb9a78..ad03746ceea76b7ea17e2d43e5d13edc13ab234a 100644
--- a/Source/modules/webaudio/AudioNode.h
+++ b/Source/modules/webaudio/AudioNode.h
@@ -138,7 +138,15 @@ public:
// Called from main thread by corresponding JavaScript methods.
virtual void connect(AudioNode*, unsigned outputIndex, unsigned inputIndex, ExceptionState&);
void connect(AudioParam*, unsigned outputIndex, ExceptionState&);
+
+ virtual void disconnect();
virtual void disconnect(unsigned outputIndex, ExceptionState&);
+ virtual void disconnect(AudioNode*, ExceptionState&);
+ virtual void disconnect(AudioNode*, unsigned outputIndex, ExceptionState&);
+ virtual void disconnect(AudioNode*, unsigned outputIndex, unsigned inputIndex, ExceptionState&);
+ virtual void disconnect(AudioParam*, ExceptionState&);
+ virtual void disconnect(AudioParam*, unsigned outputIndex, ExceptionState&);
+
// Like disconnect, but no exception is thrown if the outputIndex is invalid. Just do nothing
// in that case.
virtual void disconnectWithoutException(unsigned outputIndex);

Powered by Google App Engine
This is Rietveld 408576698