LayoutTests/webaudio/audionode-disconnect-expected.txt - Issue 886173004: Fix AudioNode.disconnect() to support selective disconnection.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/audionode-disconnect-expected.txt

Issue 886173004: Fix AudioNode.disconnect() to support selective disconnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test for AudioParam disconnection Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/webaudio/audionode-disconnect-audioparam.html ('K') | « LayoutTests/webaudio/audionode-disconnect-audioparam-expected.txt ('k') | LayoutTests/webaudio/resources/audio-testing.js » ('j') | LayoutTests/webaudio/resources/audio-testing.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Test disconnect() method.

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5 PASS ChannelData has expected values.

	6 PASS IndexSizeError was thrown as expected.
	Raymond Toy 2015/02/11 21:31:18 General comment. The old shouldThrow methods from General comment. The old shouldThrow methods from js-test.js had the nice advantage of printing out what was being tested. Now we get a stream of tests that an appropriate error was thrown, which isn't really informative when reading the expected results. Perhaps your methods should add another argument to include a (short) descriptive string that is printed out with the messages? hongchan 2015/02/12 18:38:00 A good idea. I will make it print out the summary Show quoted text On 2015/02/11 at 21:31:18, Raymond Toy wrote: > General comment. The old shouldThrow methods from js-test.js had the nice advantage of printing out what was being tested. Now we get a stream of tests that an appropriate error was thrown, which isn't really informative when reading the expected results. > > Perhaps your methods should add another argument to include a (short) descriptive string that is printed out with the messages? A good idea. I will make it print out the summary of the task (function argument).
	7 PASS Error was not thrown as expected.

	8 PASS ChannelData has expected values.

	9 PASS InvalidAccessError was thrown as expected.

	10 PASS InvalidAccessError was thrown as expected.

	11 PASS ChannelData has expected values.

	12 PASS IndexSizeError was thrown as expected.

	13 PASS InvalidAccessError was thrown as expected.

	14 PASS ChannelData has expected values.

	15 PASS InvalidAccessError was thrown as expected.

	16 PASS IndexSizeError was thrown as expected.

	17 PASS ChannelData has expected values.

	18 PASS ChannelData has expected values.

	19 PASS successfullyParsed is true

	20

	21 TEST COMPLETE

	22

OLD	NEW