components/metrics/test_metrics_service_client.cc - Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/test_metrics_service_client.cc

Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed asvitkine@'s comment and include changes for chromecast/ Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/metrics/cast_metrics_service_client.cc ('K') | « components/metrics/test_metrics_service_client.h ('k') | components/metrics/url_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/test_metrics_service_client.cc

diff --git a/components/metrics/test_metrics_service_client.cc b/components/metrics/test_metrics_service_client.cc

index c60db0b151bbc75be86c5564e0ed68453454e9bb..53cb1d93c229228c02f99e04cbd8478c8171daaa 100644

--- a/components/metrics/test_metrics_service_client.cc

+++ b/components/metrics/test_metrics_service_client.cc

@@ -65,8 +65,6 @@ void TestMetricsServiceClient::CollectFinalMetrics(

}

scoped_ptr<MetricsLogUploader> TestMetricsServiceClient::CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

const base::Callback<void(int)>& on_upload_complete) {

return scoped_ptr<MetricsLogUploader>();

}