chrome/browser/metrics/chrome_metrics_service_client.h - Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed asvitkine@'s comment and include changes for chromecast/ Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/chrome_metrics_service_client.h

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h

index 3f2e96cecbd0f413c3093b30259b9b3802ecc2a6..2b95742b3cf670e477beb56ce1e19e3579884cbb 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.h

+++ b/chrome/browser/metrics/chrome_metrics_service_client.h

@@ -67,8 +67,6 @@ class ChromeMetricsServiceClient

void StartGatheringMetrics(const base::Closure& done_callback) override;

void CollectFinalMetrics(const base::Closure& done_callback) override;

scoped_ptr<metrics::MetricsLogUploader> CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

const base::Callback<void(int)>& on_upload_complete) override;

base::string16 GetRegistryBackupKey() override;

« AUTHORS ('K') | « AUTHORS ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('J')