Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 886163005: NaCl documentation: update FAQ and examples (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
jpmedley, Sam Clegg, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl documentation: update FAQ and examples A few updates to the documentation, a developer pointed out some of the docs weren't quite clear. TBR= sbc@chromium.org, jmedley@chromium.org BUG=none TEST=none Committed: https://crrev.com/bd7a27361b8a72157ddbf25733a521022641481c Cr-Commit-Position: refs/heads/master@{#315345}

Patch Set 1 #

Patch Set 2 : Fix apps/extensions. #

Patch Set 3 : . #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -46 lines) Patch
M native_client_sdk/doc_generated/faq.html View 1 1 chunk +26 lines, -18 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/examples.html View 1 1 chunk +6 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 2 chunks +28 lines, -19 lines 2 comments Download
M native_client_sdk/src/doc/sdk/examples.rst View 1 1 chunk +7 lines, -4 lines 3 comments Download

Messages

Total messages: 19 (6 generated)
JF
5 years, 10 months ago (2015-02-07 18:15:25 UTC) #1
jpmedley
lgtm
5 years, 10 months ago (2015-02-09 16:25:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886163005/40001
5 years, 10 months ago (2015-02-09 17:41:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-09 17:41:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886163005/40001
5 years, 10 months ago (2015-02-09 17:55:32 UTC) #10
binji
lgtm https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/faq.rst File native_client_sdk/src/doc/faq.rst (right): https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/faq.rst#newcode498 native_client_sdk/src/doc/faq.rst:498: reasons these APIs are only available to `packaged ...
5 years, 10 months ago (2015-02-09 18:13:42 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 18:22:23 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bd7a27361b8a72157ddbf25733a521022641481c Cr-Commit-Position: refs/heads/master@{#315345}
5 years, 10 months ago (2015-02-09 18:23:04 UTC) #14
binji
On 2015/02/09 18:23:04, I haz the power (commit-bot) wrote: > Patchset 3 (id:??) landed as ...
5 years, 10 months ago (2015-02-09 18:54:52 UTC) #15
JF
On 2015/02/09 18:54:52, binji wrote: > On 2015/02/09 18:23:04, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-09 19:00:44 UTC) #16
JF
https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/sdk/examples.rst File native_client_sdk/src/doc/sdk/examples.rst (right): https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/sdk/examples.rst#newcode216 native_client_sdk/src/doc/sdk/examples.rst:216: <pepper_stable/cpp/classpp_1_1_u_d_p_socket>`_ or `UDP On 2015/02/09 18:13:42, binji wrote: > ...
5 years, 10 months ago (2015-02-09 19:25:40 UTC) #17
binji
https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/sdk/examples.rst File native_client_sdk/src/doc/sdk/examples.rst (right): https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/doc/sdk/examples.rst#newcode216 native_client_sdk/src/doc/sdk/examples.rst:216: <pepper_stable/cpp/classpp_1_1_u_d_p_socket>`_ or `UDP On 2015/02/09 19:25:39, JF wrote: > ...
5 years, 10 months ago (2015-02-09 21:29:51 UTC) #18
JF
5 years, 10 months ago (2015-02-09 22:32:19 UTC) #19
Message was sent while issue was closed.
On 2015/02/09 21:29:51, binji wrote:
>
https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/do...
> File native_client_sdk/src/doc/sdk/examples.rst (right):
> 
>
https://codereview.chromium.org/886163005/diff/40001/native_client_sdk/src/do...
> native_client_sdk/src/doc/sdk/examples.rst:216:
> <pepper_stable/cpp/classpp_1_1_u_d_p_socket>`_ or `UDP
> On 2015/02/09 19:25:39, JF wrote:
> > On 2015/02/09 18:13:42, binji wrote:
> > > bad link
> > 
> > Are you sure? This works:
> > 
> >
>
https://developer.chrome.com/native-client/pepper_stable/cpp/classpp_1_1_u_d_...
> 
> I mean it looks like that's a link to udp, not tcp.

ack syn, will fix.

Powered by Google App Engine
This is Rietveld 408576698