Issue 886123002: Use NoImportLib: true for blacklist_test_dll_3 to avoid unnecessary rebuilding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886123002: Use NoImportLib: true for blacklist_test_dll_3 to avoid unnecessary rebuilding (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
robertshield

CC:
chromium-reviews, caitkp+watch_chromium.org, grt (UTC plus 2)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Use NoImportLib: true for blacklist_test_dll_3 to avoid unnecessary rebuilding Avoids ninja expecting an import .lib to be generated so that it doesn't continually rebuild because the import lib is "missing". To be landed after gyp roll at https://codereview.chromium.org/890043003/ lands. R=robertshield@chromium.org BUG=342974, 451499 Committed: https://crrev.com/0c8144233a7a379f75c6291cda49939b45e85395 Cr-Commit-Position: refs/heads/master@{#314008}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome_elf/blacklist.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886123002/1

5 years, 10 months ago (2015-01-30 22:24:19 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 22:29:38 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0c8144233a7a379f75c6291cda49939b45e85395
Cr-Commit-Position: refs/heads/master@{#314008}