Make SetDisplayPower() take a callback to signal completion

chromeos/dbus/services/display_power_service_provider.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/services/display_power_service_provider.h"
 
 #include "base/bind.h"
 #include "dbus/message.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
+namespace {
+
+void DisplayConfigurationCallback(

[Daniel Erat, 2015/01/30 17:14:07]

nit: put a verb in this (RunConfigurationCallback()?)

[dnicoara, 2015/01/30 18:25:28]

Done.

+    dbus::MethodCall* method_call,
+    dbus::ExportedObject::ResponseSender response_sender,
+    bool status) {
+  response_sender.Run(dbus::Response::FromMethodCall(method_call));
+}
+
+}  // namespace
+
 DisplayPowerServiceProvider::DisplayPowerServiceProvider(
     scoped_ptr<Delegate> delegate)
     : delegate_(delegate.Pass()),
       weak_ptr_factory_(this) {
 }
 
 DisplayPowerServiceProvider::~DisplayPowerServiceProvider() {}
 
 void DisplayPowerServiceProvider::Start(
     scoped_refptr<dbus::ExportedObject> exported_object) {
@@ skipping 20 matching lines @@
     LOG(ERROR) << "Failed to export " << interface_name << "."
                << method_name;
   }
 }
 
 void DisplayPowerServiceProvider::SetDisplayPower(
     dbus::MethodCall* method_call,
     dbus::ExportedObject::ResponseSender response_sender) {
   dbus::MessageReader reader(method_call);
   int int_state = 0;
+  Delegate::ResponseCallback callback =
+      base::Bind(&DisplayConfigurationCallback, method_call, response_sender);
   if (reader.PopInt32(&int_state)) {
     DisplayPowerState state = static_cast<DisplayPowerState>(int_state);
-    delegate_->SetDisplayPower(state);
+    delegate_->SetDisplayPower(state, callback);
   } else {
     LOG(ERROR) << "Unable to parse " << kSetDisplayPower << " request";
+    callback.Run(false);
   }
-
-  response_sender.Run(dbus::Response::FromMethodCall(method_call));
 }
 
 void DisplayPowerServiceProvider::SetDisplaySoftwareDimming(
     dbus::MethodCall* method_call,
     dbus::ExportedObject::ResponseSender response_sender) {
   dbus::MessageReader reader(method_call);
   bool dimmed = false;
   if (reader.PopBool(&dimmed)) {
     delegate_->SetDimming(dimmed);
   } else {
     LOG(ERROR) << "Unable to parse " << kSetDisplaySoftwareDimming
                << " request";
   }
   response_sender.Run(dbus::Response::FromMethodCall(method_call));
 }
 
 }  // namespace chromeos