Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 885933002: [surfaces] use DEFAULT_MAX_FRAMES_PENDING if OutputSurface doesn't specify it. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[surfaces] use DEFAULT_MAX_FRAMES_PENDING if OutputSurface doesn't specify it. To match LTHI, change the max frames pending calculation to output DEFAULT_MAX_FRAMES_PENDING if the output surface reports 0. Committed: https://crrev.com/cd189c1c20e7a61442142b3cf02b99b28870553f Cr-Commit-Position: refs/heads/master@{#313800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M cc/surfaces/display.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbauman
5 years, 10 months ago (2015-01-29 21:11:40 UTC) #2
jamesr
The patch description says one thing but the code says another - isn't this doing ...
5 years, 10 months ago (2015-01-29 21:21:53 UTC) #3
jamesr
Or to put it another way DEFAULT_MAX_.. being 2 isn't a concern of this bit ...
5 years, 10 months ago (2015-01-29 21:22:17 UTC) #4
jbauman
On 2015/01/29 21:21:53, jamesr wrote: > The patch description says one thing but the code ...
5 years, 10 months ago (2015-01-29 21:25:14 UTC) #5
jamesr
lgtm
5 years, 10 months ago (2015-01-29 21:29:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885933002/1
5 years, 10 months ago (2015-01-29 21:30:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 21:59:04 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:59:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd189c1c20e7a61442142b3cf02b99b28870553f
Cr-Commit-Position: refs/heads/master@{#313800}

Powered by Google App Engine
This is Rietveld 408576698