Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 885923004: MIPS: Fix bug in elements transition code for smi to double transitions. (Closed)

Created:
5 years, 10 months ago by dusmil.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix bug in elements transition code for smi to double transitions. This fixes intermittent sin-cos test failures when corrupted values are returned for referent sin and cos functions in test which require factorial value to be calculated. TEST=mjsunit/sin-cos BUG= R=balazs.kilvady@imgtec.com Committed: https://chromium.googlesource.com/v8/v8/+/bddf5eeb39493ce911bccb6b7fc50584736aa423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dusmil.imgtec
5 years, 10 months ago (2015-01-30 15:55:47 UTC) #2
balazs.kilvady
LGTM
5 years, 10 months ago (2015-01-30 15:58:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bddf5eeb39493ce911bccb6b7fc50584736aa423 Cr-Commit-Position: refs/heads/master@{#26365}
5 years, 10 months ago (2015-01-30 16:48:46 UTC) #4
dusmil.imgtec
5 years, 10 months ago (2015-01-30 16:48:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bddf5eeb39493ce911bccb6b7fc50584736aa423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698