Overriding fields is now permissable.

Overriding fields is now permissable.

Committed: https://code.google.com/p/dart/source/detail?r=2250

[zundel, 2011-12-07 19:42:51]

At one point there must have been a prohibition against shadowing fields in
subclasses, but there is no mention of it in the spec, an there are fields that
shadow getters/setters and getters/setters that shadow fields throughout the
test and sample code.  

After discussing with Peter I am removing FieldNegativeTest and updating
FieldOverrideTest to be a positive test.

[zundel, 2011-12-07 19:44:56]

http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
File tests/language/src/FieldOverrideTest.dart (right):

http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
tests/language/src/FieldOverrideTest.dart:28: B2 field;  /// 01: static type
error
??? Dartc's type checker flags this as: 


tests/language/src/FieldOverrideTest.dart/FieldOverrideTest.dart:28: cannot
override field of Super because B2 is not assignable to B1


Makes sense to me, but I don't see it in the spec either.

[zundel, 2011-12-07 19:54:10]

http://codereview.chromium.org/8859002/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8859002/diff/1/tests/language/language.status#...
tests/language/language.status:31: FieldOverrideTest/01: Fail    # No
restriction on field shadowing
I will make a new bug and annotate these entries once the change is
acknowledged.

http://codereview.chromium.org/8859002/diff/1/tests/language/language.status#...
tests/language/language.status:229: FieldOverrideTest/01: Fail    # No
restriction on field shadowing
I will make a new bug and annotate these entries once the change is
acknowledged.

http://codereview.chromium.org/8859002/diff/1/tests/language/language.status#...
tests/language/language.status:230: Field3NegativeTest: Fail  # issue
issue 729

[ahe, 2011-12-08 08:53:45]

LGTM!

http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
File tests/language/src/FieldOverrideTest.dart (right):

http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
tests/language/src/FieldOverrideTest.dart:28: B2 field;  /// 01: static type
error
On 2011/12/07 19:44:56, zundel wrote:
> ??? Dartc's type checker flags this as: 
> 
> 
> tests/language/src/FieldOverrideTest.dart/FieldOverrideTest.dart:28: cannot
> override field of Super because B2 is not assignable to B1
> 
> 
> Makes sense to me, but I don't see it in the spec either.

Would you mind filing a specification bug?

[zundel, 2011-12-08 15:02:56]

On 2011/12/08 08:53:45, ahe wrote:
> LGTM!
> 
>
http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
> File tests/language/src/FieldOverrideTest.dart (right):
> 
>
http://codereview.chromium.org/8859002/diff/1/tests/language/src/FieldOverrid...
> tests/language/src/FieldOverrideTest.dart:28: B2 field;  /// 01: static type
> error
> On 2011/12/07 19:44:56, zundel wrote:
> > ??? Dartc's type checker flags this as: 
> > 
> > 
> > tests/language/src/FieldOverrideTest.dart/FieldOverrideTest.dart:28: cannot
> > override field of Super because B2 is not assignable to B1
> > 
> > 
> > Makes sense to me, but I don't see it in the spec either.
> 
> Would you mind filing a specification bug?

Filed: http://code.google.com/p/dart/issues/detail?id=741