Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 885853002: Disable network state reporting. (Closed)

Created:
5 years, 10 months ago by Andrew T Wilson (Slow)
Modified:
5 years, 10 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable network state reporting. Update the DeviceStatusCollector to no longer report network state. We will re-enable this for M42 once we've added code to detect an auto-launched kiosk session. BUG=452968 Committed: https://crrev.com/00fc37605e1020b8822835d5d1d9025aab76c7f9 Cr-Commit-Position: refs/heads/master@{#313717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M chrome/browser/chromeos/policy/device_status_collector.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Andrew T Wilson (Slow)
PTAL - once I land this (and merge to M41) I'll add code to check ...
5 years, 10 months ago (2015-01-29 13:49:36 UTC) #2
bartfab (slow)
lgtm
5 years, 10 months ago (2015-01-29 15:34:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885853002/1
5 years, 10 months ago (2015-01-29 16:06:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 16:10:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 16:11:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00fc37605e1020b8822835d5d1d9025aab76c7f9
Cr-Commit-Position: refs/heads/master@{#313717}

Powered by Google App Engine
This is Rietveld 408576698