Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 885813003: OOP PDF: Allow print preview to handle key events when the plugin has focus (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Allow print preview to handle key events when the plugin has focus Since the plugin is inside an iframe, key events that are sent to it when it is focussed do not propagate to the parent frame. We pass these on to the parent frame in the same way that we pass key events to the plugin when they are not handled by the print preview UI. BUG=449903 Committed: https://crrev.com/85b3edeac5068d95fc4ebeea92f1cbc1c0b27a3f Cr-Commit-Position: refs/heads/master@{#314438}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 2 5 chunks +48 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 1 2 3 4 5 2 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
raymes
5 years, 10 months ago (2015-01-30 04:15:26 UTC) #2
Sam McNally
lgtm
5 years, 10 months ago (2015-01-30 06:18:43 UTC) #3
raymes
+alekseys for chrome/browser/resources/print_preview/*
5 years, 10 months ago (2015-02-01 23:35:33 UTC) #5
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-03 21:31:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885813003/100001
5 years, 10 months ago (2015-02-03 22:55:22 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-03 23:41:22 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 23:43:59 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/85b3edeac5068d95fc4ebeea92f1cbc1c0b27a3f
Cr-Commit-Position: refs/heads/master@{#314438}

Powered by Google App Engine
This is Rietveld 408576698