Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 885803003: Pepper: PPB_VideoEncoder should be 'Dev' only for now. (Closed)

Created:
5 years, 10 months ago by bbudge
Modified:
5 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: PPB_VideoEncoder should be 'Dev' only for now. Also changes copyright notices to the new style. BUG=455409 Committed: https://crrev.com/fc2b2960d06de38985ca51023fda03b130aae6bb Cr-Commit-Position: refs/heads/master@{#314893}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix copyright notices. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M ppapi/api/ppb_video_encoder.idl View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_video_encoder.h View 1 4 chunks +4 lines, -8 lines 0 comments Download
M ppapi/cpp/video_encoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/video_encoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/ppb_video_encoder_thunk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bbudge
5 years, 10 months ago (2015-02-05 13:02:04 UTC) #2
llandwerlin-old
https://codereview.chromium.org/885803003/diff/1/ppapi/c/ppb_video_encoder.h File ppapi/c/ppb_video_encoder.h (left): https://codereview.chromium.org/885803003/diff/1/ppapi/c/ppb_video_encoder.h#oldcode23 ppapi/c/ppb_video_encoder.h:23: #define PPB_VIDEOENCODER_INTERFACE PPB_VIDEOENCODER_INTERFACE_0_1 We might want to keep this ...
5 years, 10 months ago (2015-02-05 13:05:47 UTC) #3
bbudge
5 years, 10 months ago (2015-02-05 13:08:47 UTC) #5
dmichael (off chromium)
lgtm, thanks both of you for catching & fixing this https://codereview.chromium.org/885803003/diff/1/ppapi/c/ppb_video_encoder.h File ppapi/c/ppb_video_encoder.h (left): https://codereview.chromium.org/885803003/diff/1/ppapi/c/ppb_video_encoder.h#oldcode23 ...
5 years, 10 months ago (2015-02-05 20:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885803003/20001
5 years, 10 months ago (2015-02-05 21:20:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 22:11:28 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 22:12:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc2b2960d06de38985ca51023fda03b130aae6bb
Cr-Commit-Position: refs/heads/master@{#314893}

Powered by Google App Engine
This is Rietveld 408576698