Issue 885783002: Fixes crash in HTMLIFrameElement and exposes HTMLIFrameElement::src

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885783002: Fixes crash in HTMLIFrameElement and exposes HTMLIFrameElement::src (Closed)

Created:
5 years, 10 months ago by sky

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fixes crash in HTMLIFrameElement and exposes HTMLIFrameElement::src HTMLIFrameElement was adding the observer in navigateView. If the same HTMLIFrameElement navigated multiple times HTMLIFrameElement would attach itself as an observer more than once. ObserverList doesn't like this. Also adds src as an attribute of HTMLIFrameElement so that I can do: iframe.src = xxx in script R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1f2b1c2443baecccc2b5615f8599b3dd5deeab07

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	sky/engine/core/html/HTMLIFrameElement.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	sky/engine/core/html/HTMLIFrameElement.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

5 years, 10 months ago (2015-01-29 03:47:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1f2b1c2443baecccc2b5615f8599b3dd5deeab07 (presubmit successful).

Expand Messages | Collapse Messages