Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 885763004: follow up named interceptor miss with api callback getter (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

follow up named interceptor miss with api callback getter BUG= Committed: https://crrev.com/70bba702e0c0b7b168b0b8e10842deb206cef1f4 Cr-Commit-Position: refs/heads/master@{#26395}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -18 lines) Patch
M src/ic/call-optimization.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/ic/call-optimization.cc View 1 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 4 2 chunks +33 lines, -11 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 3 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Toon Verwaest
https://codereview.chromium.org/885763004/diff/40001/src/ic/handler-compiler.cc File src/ic/handler-compiler.cc (right): https://codereview.chromium.org/885763004/diff/40001/src/ic/handler-compiler.cc#newcode302 src/ic/handler-compiler.cc:302: if (!holder()->HasFastProperties()) break; it->GetHolder<JSObject> https://codereview.chromium.org/885763004/diff/40001/src/ic/handler-compiler.cc#newcode307 src/ic/handler-compiler.cc:307: call_optimization.IsCompatibleReceiver(type(), holder()); Same ...
5 years, 10 months ago (2015-02-02 12:40:56 UTC) #2
dcarney
ptal i'll add some explicit tests if you're good with this
5 years, 10 months ago (2015-02-02 13:35:45 UTC) #3
Toon Verwaest
Lg, some tests would be nice.
5 years, 10 months ago (2015-02-02 17:23:15 UTC) #4
dcarney
On 2015/02/02 17:23:15, Toon Verwaest wrote: > Lg, some tests would be nice. done. also, ...
5 years, 10 months ago (2015-02-03 09:21:44 UTC) #5
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-03 10:47:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885763004/120001
5 years, 10 months ago (2015-02-03 10:54:55 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-02-03 10:56:17 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 10:56:38 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/70bba702e0c0b7b168b0b8e10842deb206cef1f4
Cr-Commit-Position: refs/heads/master@{#26395}

Powered by Google App Engine
This is Rietveld 408576698