Add SSL Connection Error UMA.

Add SSL Connection Error UMA.

BUG=440443
Committed: https://crrev.com/10bdf01c2eda041970ce8289d0e7525364ae7078
Cr-Commit-Position: refs/heads/master@{#313802}

[jeremyim, 2015-01-28 22:57:38]

jeremyim@chromium.org changed reviewers:
+ agl@chromium.org, asvitkine@chromium.org

[jeremyim, 2015-01-28 22:57:38]

agl => ssl_client_socket_openssl.cc
asvitkine => histograms.xml

Thank you!

[Alexei Svitkine (slow), 2015-01-29 16:51:24]

https://codereview.chromium.org/885763002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/885763002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:19152: +<histogram
name="Net.SSL_Connection_Error_Google" enum="NetErrorCodes">
I don't see where this is logged?

[jeremyim, 2015-01-29 17:40:43]

https://codereview.chromium.org/885763002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/885763002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:19152: +<histogram
name="Net.SSL_Connection_Error_Google" enum="NetErrorCodes">
On 2015/01/29 16:51:24, Alexei Svitkine wrote:
> I don't see where this is logged?

This will come in https://codereview.chromium.org/869393005 (or a variant
thereof).

[Alexei Svitkine (slow), 2015-01-29 18:09:44]

I would move that part of the change to that CL then.

On Thu, Jan 29, 2015 at 12:40 PM, <jeremyim@chromium.org> wrote:

>
> https://codereview.chromium.org/885763002/diff/1/tools/
> metrics/histograms/histograms.xml
> File tools/metrics/histograms/histograms.xml (right):
>
> https://codereview.chromium.org/885763002/diff/1/tools/
> metrics/histograms/histograms.xml#newcode19152
> tools/metrics/histograms/histograms.xml:19152: +<histogram
> name="Net.SSL_Connection_Error_Google" enum="NetErrorCodes">
> On 2015/01/29 16:51:24, Alexei Svitkine wrote:
>
>> I don't see where this is logged?
>>
>
> This will come in https://codereview.chromium.org/869393005 (or a
> variant thereof).
>
> https://codereview.chromium.org/885763002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jeremyim, 2015-01-29 18:19:43]

Done.

On 2015/01/29 18:09:44, Alexei Svitkine wrote:
> I would move that part of the change to that CL then.
> 
> On Thu, Jan 29, 2015 at 12:40 PM, <mailto:jeremyim@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/885763002/diff/1/tools/
> > metrics/histograms/histograms.xml
> > File tools/metrics/histograms/histograms.xml (right):
> >
> > https://codereview.chromium.org/885763002/diff/1/tools/
> > metrics/histograms/histograms.xml#newcode19152
> > tools/metrics/histograms/histograms.xml:19152: +<histogram
> > name="Net.SSL_Connection_Error_Google" enum="NetErrorCodes">
> > On 2015/01/29 16:51:24, Alexei Svitkine wrote:
> >
> >> I don't see where this is logged?
> >>
> >
> > This will come in https://codereview.chromium.org/869393005 (or a
> > variant thereof).
> >
> > https://codereview.chromium.org/885763002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-01-29 19:55:37]

LGTM

https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
net/socket/ssl_client_socket_openssl.cc:472:
UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSL_Connection_Error", std::abs(rv));
Nit: How about making a helper function that combined this line with the line
above and calling it from all three places?

[agl, 2015-01-29 20:23:00]

lgtm

https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
File net/socket/ssl_client_socket_openssl.cc (right):

https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
net/socket/ssl_client_socket_openssl.cc:472:
UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSL_Connection_Error", std::abs(rv));
On 2015/01/29 19:55:37, Alexei Svitkine wrote:
> Nit: How about making a helper function that combined this line with the line
> above and calling it from all three places?

I'd actually tend towards being clearer at the cost of a little duplication here
but don't have strong feelings.

[jeremyim, 2015-01-29 20:24:58]

The CQ bit was checked by jeremyim@chromium.org

[jeremyim, 2015-01-29 20:25:17]

On 2015/01/29 20:23:00, agl wrote:
> lgtm
> 
>
https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
> File net/socket/ssl_client_socket_openssl.cc (right):
> 
>
https://codereview.chromium.org/885763002/diff/20001/net/socket/ssl_client_so...
> net/socket/ssl_client_socket_openssl.cc:472:
> UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSL_Connection_Error", std::abs(rv));
> On 2015/01/29 19:55:37, Alexei Svitkine wrote:
> > Nit: How about making a helper function that combined this line with the
line
> > above and calling it from all three places?
> 
> I'd actually tend towards being clearer at the cost of a little duplication
here
> but don't have strong feelings.

I'll leave it duplicated for clarity. Thanks everybody!

[commit-bot: I haz the power, 2015-01-29 20:25:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885763002/20001

[commit-bot: I haz the power, 2015-01-29 22:05:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-29 22:07:08]

Patchset 2 (id:??) landed as
https://crrev.com/10bdf01c2eda041970ce8289d0e7525364ae7078
Cr-Commit-Position: refs/heads/master@{#313802}