Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 885753004: Revert of Report viewport memory and timing correctly for Slimming Paint. (Closed)

Created:
5 years, 10 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Report viewport memory and timing correctly for Slimming Paint. (patchset #3 id:60001 of https://codereview.chromium.org/867803003/) Reason for revert: Reverting due to https://crbug.com/453131 Original issue's description: > Report viewport memory and timing correctly for Slimming Paint. > > The rasterize_and_record benchmark was not using data from the > DisplayItemList. Now it does. > > R=ajuma@chromium.org,vmpstr@chromium.org > BUG=451448 > > Committed: https://crrev.com/c76f528131949d7fe60b7facf1e7b40362aacfd5 > Cr-Commit-Position: refs/heads/master@{#313420} TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451448 Committed: https://crrev.com/fae3da55913e8e163faabf787b26791a96938ab7 Cr-Commit-Position: refs/heads/master@{#314226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -86 lines) Patch
M cc/debug/rasterize_and_record_benchmark.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 6 chunks +10 lines, -82 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Report viewport memory and timing correctly for Slimming Paint.
5 years, 10 months ago (2015-02-03 00:36:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885753004/1
5 years, 10 months ago (2015-02-03 00:36:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 00:38:26 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fae3da55913e8e163faabf787b26791a96938ab7 Cr-Commit-Position: refs/heads/master@{#314226}
5 years, 10 months ago (2015-02-03 00:39:32 UTC) #4
oystein (OOO til 10th of July)
5 years, 10 months ago (2015-02-03 03:30:38 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/886673003/ by oysteine@chromium.org.

The reason for reverting is: This CL wasn't the culprit after all, it seems..

Powered by Google App Engine
This is Rietveld 408576698