Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 885753002: Fixing the super-long delay when GCMAccountTracker posts a task (Closed)

Created:
5 years, 10 months ago by fgorski
Modified:
5 years, 10 months ago
Reviewers:
miu
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing the super-long delay when GCMAccountTracker posts a task * In order to sort out dependencies between initialization of components, I am doing work only when I have a valid GCM connection going (this means all the infrastructure is up and running). * I am also making sure that time to next token reporting is always between 0 and 12 hours. BUG=453018 Committed: https://crrev.com/702e92edc36eecb6d77d97947929c2e31775bd71 Cr-Commit-Position: refs/heads/master@{#313754}

Patch Set 1 #

Patch Set 2 : Adding dependnecy on GCM Driver being connected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M chrome/browser/services/gcm/gcm_account_tracker.cc View 1 3 chunks +23 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
lgtm, but didn't you also want to fix the code in GCMStoreImpl::Backend::LoadLastTokenFetchTime(), where base::StringToInt64() is ...
5 years, 10 months ago (2015-01-28 23:20:14 UTC) #2
fgorski
On 2015/01/28 23:20:14, miu wrote: > lgtm, but didn't you also want to fix the ...
5 years, 10 months ago (2015-01-28 23:57:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885753002/20001
5 years, 10 months ago (2015-01-29 18:39:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 19:22:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:23:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/702e92edc36eecb6d77d97947929c2e31775bd71
Cr-Commit-Position: refs/heads/master@{#313754}

Powered by Google App Engine
This is Rietveld 408576698