Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 885733002: Fold gmtoskp into DM, as --src gm --config skp. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fold gmtoskp into DM, as --src gm --config skp. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9c3f17d6e859a11535f40497cb9f6e777d15f62e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -102 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +9 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
D experimental/tools/gmtoskp.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M gyp/experimental.gyp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 10 months ago (2015-01-28 19:28:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885733002/1
5 years, 10 months ago (2015-01-28 19:28:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-28 19:28:55 UTC) #5
hal.canary
LGTM
5 years, 10 months ago (2015-01-28 19:30:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:35:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9c3f17d6e859a11535f40497cb9f6e777d15f62e

Powered by Google App Engine
This is Rietveld 408576698