Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 885703002: ozone: Fix chromium-style method override warnings (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, tdresser+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Fix chromium-style method override warnings BUG=417463 TEST=build with clang plugin Committed: https://crrev.com/6600b3d9df17f9aa443ebea43e0b016919e9da3e Cr-Commit-Position: refs/heads/master@{#313561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ui/events/ozone/chromeos/cursor_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 10 months ago (2015-01-28 18:42:52 UTC) #2
alexst (slow to review)
lgtm
5 years, 10 months ago (2015-01-28 18:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885703002/1
5 years, 10 months ago (2015-01-28 18:48:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 19:40:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:41:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6600b3d9df17f9aa443ebea43e0b016919e9da3e
Cr-Commit-Position: refs/heads/master@{#313561}

Powered by Google App Engine
This is Rietveld 408576698