Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 885693005: Turn off bind_generates_resource in Mojo's GL (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Turn off bind_generates_resource in Mojo's GL We don't need bind to generate resources in Mojo. Turning this off causes Ganesh to run faster because it flushes the GL command stream less often. R=jamesr@chromium.org BUG=451190 Committed: https://chromium.googlesource.com/external/mojo/+/c53ca4b992ada14f4c9463f529107beb7e7ca93f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/cc/context_provider_mojo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/gles2/command_buffer_driver.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-01-28 23:29:42 UTC) #1
jamesr
lgtm https://codereview.chromium.org/885693005/diff/1/services/gles2/command_buffer_driver.cc File services/gles2/command_buffer_driver.cc (left): https://codereview.chromium.org/885693005/diff/1/services/gles2/command_buffer_driver.cc#oldcode129 services/gles2/command_buffer_driver.cc:129: nullptr, nullptr, nullptr, true); can you extract this ...
5 years, 10 months ago (2015-01-28 23:41:53 UTC) #2
abarth-chromium
https://codereview.chromium.org/885693005/diff/1/services/gles2/command_buffer_driver.cc File services/gles2/command_buffer_driver.cc (left): https://codereview.chromium.org/885693005/diff/1/services/gles2/command_buffer_driver.cc#oldcode129 services/gles2/command_buffer_driver.cc:129: nullptr, nullptr, nullptr, true); On 2015/01/28 at 23:41:53, jamesr ...
5 years, 10 months ago (2015-01-28 23:42:51 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-01-28 23:55:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c53ca4b992ada14f4c9463f529107beb7e7ca93f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698