Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 885693003: Fix DCHECK(!config_watcher_) in HostProcess::~HostProcess(). (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_script
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK(!config_watcher_) in HostProcess::~HostProcess(). When shutting down HostProcess config_watcher_ is supposed to be deleted on the nework thread. Previously ShutdownOnNetworkThread() was deleting it, but that line was mistakenly removed in crrev.com/302162 . Adding it back. Committed: https://crrev.com/846e3642f9f54db916a5141f26a368f1c7aa0095 Cr-Commit-Position: refs/heads/master@{#313623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sergey Ulanov
5 years, 10 months ago (2015-01-28 19:00:16 UTC) #2
kelvinp
lgtm
5 years, 10 months ago (2015-01-28 20:43:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885693003/1
5 years, 10 months ago (2015-01-28 20:47:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/29727)
5 years, 10 months ago (2015-01-28 22:26:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885693003/1
5 years, 10 months ago (2015-01-28 23:19:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 23:54:40 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 23:56:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/846e3642f9f54db916a5141f26a368f1c7aa0095
Cr-Commit-Position: refs/heads/master@{#313623}

Powered by Google App Engine
This is Rietveld 408576698