Source/platform/graphics/Canvas2DLayerBridge.cpp - Issue 885673005: Fixing crash during 2D canvas destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/Canvas2DLayerBridge.cpp

Issue 885673005: Fixing crash during 2D canvas destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add null check Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/Canvas2DLayerBridge.cpp

diff --git a/Source/platform/graphics/Canvas2DLayerBridge.cpp b/Source/platform/graphics/Canvas2DLayerBridge.cpp

index f4b28f8a86d367aa2ddd2b771eb50a2d4c5c2dda..6b785cf5b98f819a2661d9e15a8a480540922bcc 100644

--- a/Source/platform/graphics/Canvas2DLayerBridge.cpp

+++ b/Source/platform/graphics/Canvas2DLayerBridge.cpp

@@ -120,6 +120,8 @@ Canvas2DLayerBridge::~Canvas2DLayerBridge()

{

ASSERT(m_destructionInProgress);

ASSERT(!Canvas2DLayerManager::get().isInList(this));

+ if (m_canvas)

+ m_canvas->setNotificationClient(nullptr);

m_layer.clear();

ASSERT(m_mailboxes.size() == 0);

#ifndef NDEBUG

« no previous file with comments | « no previous file | no next file » | no next file with comments »