Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder.dart

Issue 885673002: dart2js: Address comments from CL 871073002. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dart2js_incremental/lib/library_updater.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index 0f1f7ee778973a896c8a8e0b66b05599d37e9e05..a2fc45a1a0d00586c514bac55a3c4c33337c1a25 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -278,25 +278,20 @@ class ProgramBuilder {
staticFieldsForReflection);
}
- /// HACK for Try.
+ /// HACK for Incremental Compilation.
///
/// Returns a class that contains the fields of a class.
- Class buildClassWithFieldsForTry(ClassElement element) {
- bool onlyForRti = _task.typeTestRegistry.rtiNeededClasses.contains(element);
+ Class buildClassWithFieldsForIncrementalCompilation(ClassElement element) {
+ assert(_compiler.hasIncrementalSupport);
- List<Field> instanceFields =
- onlyForRti ? const <Field>[] : _buildFields(element, false);
+ List<Field> instanceFields = _buildFields(element, false);
String name = namer.getNameOfClass(element);
- String holderName = namer.globalObjectFor(element);
- Holder holder = _registry.registerHolder(holderName);
- bool isInstantiated =
- _compiler.codegenWorld.directlyInstantiatedClasses.contains(element);
return new Class(
- element, name, holder, [], instanceFields, [], [], [], null,
- isDirectlyInstantiated: isInstantiated,
- onlyForRti: onlyForRti,
+ element, name, null, [], instanceFields, [], [], [], null,
+ isDirectlyInstantiated: true,
+ onlyForRti: false,
isNative: element.isNative);
}
« no previous file with comments | « no previous file | pkg/dart2js_incremental/lib/library_updater.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698