Modify CloudPolicyClient to support multiple concurrent requests.

Modify CloudPolicyClient to support multiple concurrent requests.

CloudPolicyClient previously only allowed a single outstanding request at once,
and issuing a new request would cause the previous request to silently fail.
This behavior made sense for policy fetches, but not for other types of
out-of-band requests (status uploads, certificate uploads, etc).

CloudPolicyClient now allows multiple requests at once, and differentiates
between policy-fetch/registration related requests and out-of-band requests.

BUG=452563
Committed: https://crrev.com/4d7bcd649f45b21838e41a9174568c6db6373786
Cr-Commit-Position: refs/heads/master@{#315084}

[Andrew T Wilson (Slow), 2015-02-06 12:24:36]

atwilson@chromium.org changed reviewers:
+ bartfab@chromium.org

[Andrew T Wilson (Slow), 2015-02-06 12:24:36]

PTAL

[bartfab (slow), 2015-02-06 14:41:01]

lgtm

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client.cc:493: for
(ScopedVector<DeviceManagementRequestJob>::iterator it =
Nit: You can use C++11 |for (auto it : request_jobs_)|

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client.h (right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client.h:221: int
GetActiveRequestCountForTest();
Nit: Mark this method const.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client_unittest.cc
(right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:617:
base::Unretained(&upload_observer_));
Nit: #include "base/bind_helpers.h"

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:635: //
Setup pending upload status job.
Nit: s/Setup/Set up/ (the former is a noun, the latter is a verb)

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:649: //
Setup pending upload certificate job.
Nit: s/Setup/Set up/

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:699: //
Setup pending upload status job.
Nit: s/Setup/Set up/

[Andrew T Wilson (Slow), 2015-02-06 17:54:56]

New patchsets have been uploaded after l-g-t-m from bartfab@chromium.org

[Andrew T Wilson (Slow), 2015-02-06 18:23:31]

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client.cc (right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client.cc:493: for
(ScopedVector<DeviceManagementRequestJob>::iterator it =
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: You can use C++11 |for (auto it : request_jobs_)|

Done.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client.h (right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client.h:221: int
GetActiveRequestCountForTest();
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: Mark this method const.

Done.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
File components/policy/core/common/cloud/cloud_policy_client_unittest.cc
(right):

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:617:
base::Unretained(&upload_observer_));
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: #include "base/bind_helpers.h"

Done.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:635: //
Setup pending upload status job.
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: s/Setup/Set up/ (the former is a noun, the latter is a verb)

Done.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:649: //
Setup pending upload certificate job.
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: s/Setup/Set up/

Done.

https://codereview.chromium.org/885653007/diff/20001/components/policy/core/c...
components/policy/core/common/cloud/cloud_policy_client_unittest.cc:699: //
Setup pending upload status job.
On 2015/02/06 14:41:01, bartfab wrote:
> Nit: s/Setup/Set up/ 

Done.

[Andrew T Wilson (Slow), 2015-02-06 18:23:34]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885653007/40001

[commit-bot: I haz the power, 2015-02-06 19:24:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 19:25:16]

Patchset 3 (id:??) landed as
https://crrev.com/4d7bcd649f45b21838e41a9174568c6db6373786
Cr-Commit-Position: refs/heads/master@{#315084}