Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 885653002: Re-layout grid view and add check marks for selected items. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-layout grid view and add check marks for selected items. Changes are: - Changed layout of grid view. - Made thumbnails fill entire item area. - Use check marks to indicate selected items. BUG=402344 TEST=run browser_tests Committed: https://crrev.com/bf8d3d26979fe7c72cc5754050fafedcb6d40f74 Cr-Commit-Position: refs/heads/master@{#313651}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +35 lines, -21 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/2x/thumbnail_checked.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/files/ui/thumbnail_checked.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
Awano-san, could you take a look? Thanks!
5 years, 10 months ago (2015-01-28 14:49:23 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-01-29 02:17:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885653002/20001
5 years, 10 months ago (2015-01-29 02:19:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 02:37:53 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 02:40:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf8d3d26979fe7c72cc5754050fafedcb6d40f74
Cr-Commit-Position: refs/heads/master@{#313651}

Powered by Google App Engine
This is Rietveld 408576698