Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 885643004: new classes: assert that constructors are not callable and rewrite 'return;' (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

new classes: assert that constructors are not callable and rewrite 'return;' R=arv@chromium.org BUG=v8:3834 LOG=N Committed: https://crrev.com/158a87659f02ad4d5e41d2dc19eec1f0f4ded41f Cr-Commit-Position: refs/heads/master@{#26483}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix turbo deopt #

Patch Set 3 : Rebased + fix turbo deopt issue #

Patch Set 4 : Fix bit width #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -57 lines) Patch
M src/ast.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/ast-value-factory.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/globals.h View 1 2 3 chunks +17 lines, -1 line 0 comments Download
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/parser.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/parser.cc View 1 2 11 chunks +45 lines, -10 lines 0 comments Download
M src/preparser.h View 1 2 13 chunks +24 lines, -24 lines 0 comments Download
M src/preparser.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 10 months ago (2015-02-05 19:58:56 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/885643004/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/885643004/diff/1/test/mjsunit/mjsunit.status#newcode112 test/mjsunit/mjsunit.status:112: # Issue 3869: --turbo-deoptimnization issues (jarin, dslomov). typo
5 years, 10 months ago (2015-02-05 20:49:46 UTC) #2
Dmitry Lomov (no reviews)
Rebased + turbo deopt fix. Landing, but PTAL
5 years, 10 months ago (2015-02-06 09:34:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885643004/40001
5 years, 10 months ago (2015-02-06 09:35:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2728)
5 years, 10 months ago (2015-02-06 09:52:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885643004/60001
5 years, 10 months ago (2015-02-06 10:12:43 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-06 10:34:58 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 10:35:20 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/158a87659f02ad4d5e41d2dc19eec1f0f4ded41f
Cr-Commit-Position: refs/heads/master@{#26483}

Powered by Google App Engine
This is Rietveld 408576698