Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build_apprtc_closure.py

Issue 885613002: Fixing workaround for long paths. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_apprtc_closure.py
===================================================================
--- build_apprtc_closure.py (revision 293837)
+++ build_apprtc_closure.py (working copy)
@@ -22,6 +22,8 @@
def _WorkaroundPhantomJsOnWin(samples_path):
if utils.GetPlatform() is 'win':
package_json = os.path.join(samples_path, 'package.json')
+ if not os.path.exists(package_json):
+ raise Exception('Expected %s to exist.' % os.path.abspath(package_json))
for line in fileinput.input(package_json, inplace=True):
if not 'phantomjs' in line:
@@ -36,8 +38,8 @@
if not os.path.exists(samples_path):
return 'Expected webrtc-samples at %s.' % os.path.abspath(samples_path)
+ _WorkaroundPhantomJsOnWin(samples_path)
os.chdir(samples_path)
- _WorkaroundPhantomJsOnWin(samples_path)
if utils.GetPlatform() is 'win':
npm_bin = os.path.join(node_path, 'npm.cmd')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698