Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 885593002: Continue learning for calls in crankshaft. (Closed)

Created:
5 years, 10 months ago by mvstanton
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Continue learning for calls in crankshaft. The type feedback vector makes this easy to do. This is a re-land of https://codereview.chromium.org/868453005/ with a fix for the DCHECK failure. Committed: https://crrev.com/7d363783e14433032a4e8dd426fe0e27d1637fe5 Cr-Commit-Position: refs/heads/master@{#26302}

Patch Set 1 #

Patch Set 2 : SLOW_DCHECK fix. #

Patch Set 3 : Remove inlining text size limit and bump node limit. #

Patch Set 4 : Don't remove inlining text size limit yet, just alter it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -35 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +24 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +24 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 3 1 chunk +13 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +21 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +24 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +30 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +24 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
mvstanton
Hi Toon, Here is a re-land of the crankshaft learning CL with a fix for ...
5 years, 10 months ago (2015-01-28 06:30:05 UTC) #2
mvstanton
Results look to be good with inlining limit changes as suggested by Toon. Benedikt, can ...
5 years, 10 months ago (2015-01-28 08:10:14 UTC) #4
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-01-28 08:10:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885593002/40001
5 years, 10 months ago (2015-01-28 08:11:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885593002/40001
5 years, 10 months ago (2015-01-28 08:18:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2387)
5 years, 10 months ago (2015-01-28 08:25:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885593002/60001
5 years, 10 months ago (2015-01-28 08:34:59 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-28 09:03:12 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 09:03:29 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7d363783e14433032a4e8dd426fe0e27d1637fe5
Cr-Commit-Position: refs/heads/master@{#26302}

Powered by Google App Engine
This is Rietveld 408576698