Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 885573005: Update comment for SkMallocPixelRef::NewWithProc. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update comment for SkMallocPixelRef::NewWithProc. Add a comment about using a NULL ReleaseProc. BUG=skia:2185 Committed: https://skia.googlesource.com/skia/+/527b28732d0366373cdf4c3c3c496c7500523e74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/core/SkMallocPixelRef.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scroggo
5 years, 10 months ago (2015-01-29 21:18:33 UTC) #2
hal.canary
lgtm
5 years, 10 months ago (2015-01-29 21:31:43 UTC) #3
reed1
lgtm
5 years, 10 months ago (2015-01-29 21:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885573005/1
5 years, 10 months ago (2015-01-29 21:46:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:52:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/527b28732d0366373cdf4c3c3c496c7500523e74

Powered by Google App Engine
This is Rietveld 408576698